driver: bt: esp32: use BUILD_ONLY_NO_BLOBS to allow CI tests #80786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvioalves
force-pushed
the
enh/make_bluetooth_build_only_global
branch
from
311bfd1 to
3128271
Compare
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
sylvioalves
force-pushed
the
enh/make_bluetooth_build_only_global
branch
from
3128271 to
b81a41a
Compare
|
As suggested in zephyrproject-rtos/hal_espressif#359 (comment) I think it would make sense to just have one option for all of this, since it's all about doing CI compile testing without blobs present. The specific feature(s) that blobs are needed for seems secondary. |
sylvioalves
force-pushed
the
enh/make_bluetooth_build_only_global
branch
from
b81a41a to
9bf0ebe
Compare
sylvioalves
changed the title
sylvioalves
force-pushed
the
enh/make_bluetooth_build_only_global
branch
from
9bf0ebe to
0346dc0
Compare
|
This is starting to look pretty good to me. I'm hoping to get |
sylvioalves
force-pushed
the
enh/make_bluetooth_build_only_global
branch
from
0346dc0 to
73f3897
Compare
zephyrbot
added
area: Samples
zephyrbot
requested review from
alwa-nordic,
cvinayak,
hermabe,
HoZHel,
jhedberg,
kartben,
LucasTambor and
marekmatej
sylvioalves
force-pushed
the
enh/make_bluetooth_build_only_global
branch
from
73f3897 to
c286e1e
Compare
|
PR is ready. |
jhedberg
previously approved these changes
Dec 18, 2024
wmrsouza
previously approved these changes
Dec 18, 2024
raffarost
previously approved these changes
Dec 18, 2024
uLipe
previously approved these changes
Dec 18, 2024
|
@sylvioalves there's a bunch of conflicts that need fixing |
sylvioalves
dismissed stale reviews from uLipe, raffarost, wmrsouza, and jhedberg
via
fd3dd76
sylvioalves
force-pushed
the
enh/make_bluetooth_build_only_global
branch
from
c286e1e to
fd3dd76
Compare
jhedberg
previously approved these changes
Dec 19, 2024
wmrsouza
previously approved these changes
Dec 19, 2024
|
@sylvioalves this will need a rebase |
Adds an option to enable CI tests without binary blobs. Signed-off-by: Sylvio Alves <[email protected]>
Update central and peripheral samples so that espressif SoC can be properly tested in CI. Signed-off-by: Sylvio Alves <[email protected]>
Remove bluetooth ignore tag so it can run CI tests whenever platform is filtered. Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
force-pushed
the
enh/make_bluetooth_build_only_global
branch
from
fd3dd76 to
100af98
Compare
wmrsouza
approved these changes
Dec 20, 2024
jhedberg
approved these changes
Dec 20, 2024
raffarost
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add BUILD_ONLY_NO_BLOBS to allow CI tests.
Read this before: #80785
Depends on #82931 due to HAL merging sequence.